Почему мои тесты RSpec не проходят, но мое приложение работает?

Я только что закончил главу 10 Руководства по Ruby on Rails , добавив возможность редактировать / обновлять, индексировать, и уничтожить пользователей. В моем приложении все работает правильно, но многие из моих тестов не работают, когда я запускаю RSpec.

У меня user_controller_spec настроен точно так же, как это сделано в книге, и мой код приложения тоже такой же. Может ли проблема заключаться в том, что я использую Rails 3.1.1, а не Rails 3.0, который он использует в книге? На самом деле это не было проблемой для предыдущих тестов, просто иногда для нескольких разных строк кода. Проблемы начали появляться после того, как я запустил раздел 10.2.1 .

Вот список ошибок, которые я вижу. Пожалуйста, дайте мне знать, если вам понадобится дополнительная информация. Спасибо!

1) UsersController GET 'index' for signed-in users should be successful
 Failure/Error: response.should be_success
   expected success? to return true, got false
 # ./spec/controllers/users_controller_spec.rb:31:in `block (4 levels) in '

2) UsersController GET 'index' for signed-in users should have the right title
 Failure/Error: response.should have_selector("title", :content => "All users")
   expected following output to contain a All users tag:
   
   You are being redirected.
 # ./spec/controllers/users_controller_spec.rb:36:in `block (4 levels) in '

3) UsersController GET 'index' for signed-in users should have an element for each user
 Failure/Error: response.should have_selector("li", :content => user.name)
   expected following output to contain a 
  • Richard Berger
  • tag: You are being redirected. # ./spec/controllers/users_controller_spec.rb:42:in `block (5 levels) in ' # ./spec/controllers/users_controller_spec.rb:41:in `each' # ./spec/controllers/users_controller_spec.rb:41:in `block (4 levels) in ' 4) UsersController GET 'index' for signed-in users should paginate users Failure/Error: response.should have_selector("div.pagination") expected following output to contain a tag: You are being redirected. # ./spec/controllers/users_controller_spec.rb:48:in `block (4 levels) in ' 5) UsersController GET 'edit' should be successful Failure/Error: response.should be_success expected success? to return true, got false # ./spec/controllers/users_controller_spec.rb:184:in `block (3 levels) in ' 6) UsersController GET 'edit' should have the right title Failure/Error: response.should have_selector("title", :content => "Edit user") expected following output to contain a Edit user tag: You are being redirected. # ./spec/controllers/users_controller_spec.rb:189:in `block (3 levels) in ' 7) UsersController GET 'edit' should have a link to change the Gravatar Failure/Error: response.should have_selector("a", :href => gravatar_url, :content => "change") expected following output to contain a change tag: You are being redirected. # ./spec/controllers/users_controller_spec.rb:195:in `block (3 levels) in ' 8) UsersController PUT 'update' failure should render the 'edit' page Failure/Error: response.should render_template('edit') expecting <"edit"> but rendering with <""> # ./spec/controllers/users_controller_spec.rb:214:in `block (4 levels) in ' 9) UsersController PUT 'update' failure should have the right title Failure/Error: response.should have_selector("title", :content => "Edit user") expected following output to contain a Edit user tag: You are being redirected. # ./spec/controllers/users_controller_spec.rb:219:in `block (4 levels) in ' 10) UsersController PUT 'update' success should change the user's attributes Failure/Error: @user.name.should == @attr[:name] expected: "New Name" got: "Richard Berger" (using ==) # ./spec/controllers/users_controller_spec.rb:232:in `block (4 levels) in ' 11) UsersController PUT 'update' success should redirect to the user show page Failure/Error: response.should redirect_to(user_path(@user)) Expected response to be a redirect to but was a redirect to # ./spec/controllers/users_controller_spec.rb:238:in `block (4 levels) in ' 12) UsersController PUT 'update' success should have a flash message Failure/Error: flash[:success].should =~ /updated/ expected: /updated/ got: nil (using =~) # ./spec/controllers/users_controller_spec.rb:243:in `block (4 levels) in ' 13) UsersController authentication of edit/update pages for signed-in users should require matching users for 'edit' Failure/Error: response.should redirect_to(root_path) Expected response to be a redirect to but was a redirect to # ./spec/controllers/users_controller_spec.rb:276:in `block (4 levels) in ' 14) UsersController authentication of edit/update pages for signed-in users should require matching users for 'update' Failure/Error: response.should redirect_to(root_path) Expected response to be a redirect to but was a redirect to # ./spec/controllers/users_controller_spec.rb:281:in `block (4 levels) in ' 15) UsersController DELETE 'destroy' as a non-admin user should protect the page Failure/Error: response.should redirect_to(root_path) Expected response to be a redirect to but was a redirect to # ./spec/controllers/users_controller_spec.rb:303:in `block (4 levels) in ' 16) UsersController DELETE 'destroy' as an admin user should destroy the user Failure/Error: lambda do count should have been changed by -1, but was changed by 0 # ./spec/controllers/users_controller_spec.rb:315:in `block (4 levels) in ' 17) UsersController DELETE 'destroy' as an admin user should redirect to the users page Failure/Error: response.should redirect_to(users_path) Expected response to be a redirect to but was a redirect to # ./spec/controllers/users_controller_spec.rb:322:in `block (4 levels) in '

    ОБНОВЛЕНИЕ:

    Я решил 2 ошибки, но большинство из них все еще сохраняются. Одна из проблем заключается в том, что когда тест пытается «get: index», он не находит правильную страницу из-за перенаправления (на страницу / signin). Я не вводил никаких перенаправлений (во всяком случае специально), но, может быть, кто-то знает, как это могло произойти и как это можно исправить?

    ОБНОВЛЕНИЕ №2:

    По запросу @bkempner, вот соответствующий код из users_controller_spec и users_controller (сначала users_controller_spec). Много кода, но много ошибок ...:

    describe "for signed-in users" do
    
      before(:each) do
        @user = test_sign_in(Factory(:user))
        second = Factory(:user, :email => "another@example.com")
        third  = Factory(:user, :email => "another@example.net")
    
        @users = [@user, second, third]
        30.times do
          @users << Factory(:user, :email => Factory.next(:email))
        end
      end
    
      it "should be successful" do
        get :index
        response.should be_success
      end
    
      it "should have the right title" do
        get :index
        response.should have_selector("title", :content => "All users")
      end
    
      it "should have an element for each user" do
        get :index
        @users[0..2].each do |user|
          response.should have_selector("li", :content => user.name)
        end
      end
    
      it "should paginate users" do
        get :index
        response.should have_selector("div.pagination")
        response.should have_selector("span.diabled", :content => "Previous")
        response.should have_selector("a", :href => "/users?page=2", :content => "2")
        response.should have_selector("a", :href => "/users?page=2", :content => "Next")
      end
    end
    
    describe "GET 'edit'" do
    
      before(:each) do
        @user = Factory(:user)
        test_sign_in(@user)
      end
    
      it "should be successful" do
        get :edit, :id => @user
        response.should be_success
      end
    
      it "should have the right title" do
        get :edit, :id => @user
        response.should have_selector("title", :content => "Edit user")
      end
    
      it "should have a link to change the Gravatar" do
        get :edit, :id => @user
        gravatar_url = "http://gravatar.com/emails"
        response.should have_selector("a", :href => gravatar_url, :content => "change")
      end
    end
    
    describe "PUT 'update'" do
    
      before(:each) do
        @user = Factory(:user)
        test_sign_in(@user)
      end
    
      describe "failure" do
    
        before(:each) do
          @attr = { :email => "", :name => "", :password => "", :password_confirmation => "" }
        end
    
        it "should render the 'edit' page" do
          put :update, :id => @user, :user => @attr
          response.should render_template('edit')
        end
    
        it "should have the right title" do
          put :update, :id => @user, :user => @attr
          response.should have_selector("title", :content => "Edit user")
        end
      end
    
      describe "success" do
    
        before(:each) do
          @attr = { :name => "New Name", :email => "user@example.org", :password => "barbaz", :password_confirmation => "barbaz" }
        end
    
        it "should change the user's attributes" do
          put :update, :id => @user, :user => @attr
          @user.reload
          @user.name.should  == @attr[:name]
          @user.email.should == @attr[:email]
        end
    
        it "should redirect to the user show page" do
          put :update, :id => @user, :user => @attr
          response.should redirect_to(user_path(@user))
        end
    
        it "should have a flash message" do
          put :update, :id => @user, :user => @attr
          flash[:success].should =~ /updated/
        end
      end
    end
    
    describe "authentication of edit/update pages" do
    
      describe "for signed-in users" do
    
        before(:each) do
          wrong_user = Factory(:user, :email => "user@example.net")
          test_sign_in(wrong_user)
        end
    
        it "should require matching users for 'edit'" do
          get :edit, :id => @user
          response.should redirect_to(root_path)
        end
    
        it "should require matching users for 'update'" do
          get :update, :id => @user, :user => {}
          response.should redirect_to(root_path)
        end
      end
    end
    
    describe "DELETE 'destroy'" do
    
      before(:each) do
        @user = Factory(:user)
      end
    
      describe "as a non-admin user" do
        it "should protect the page" do
          test_sign_in(@user)
          delete :destroy, :id => @user
          response.should redirect_to(root_path)
        end
      end
    
      describe "as an admin user" do
    
        before(:each) do
          admin = Factory(:user, :email => "admin@example.com", :admin => true)
          test_sign_in(admin)
        end
    
        it "should destroy the user" do
          lambda do
            delete :destroy, :id => @user
          end.should change(User, :count).by(-1)
        end
    
        it "should redirect to the users page" do
          delete :destroy, :id => @user
          response.should redirect_to(users_path)
        end
      end
    end
    

    А теперь весь users_controller:

    class UsersController < ApplicationController
    before_filter :authenticate, :only => [:index, :edit, :update, :destroy]
    before_filter :correct_user, :only => [:edit, :update]
    before_filter :admin_user,   :only => :destroy
    
    def index
      @title = "All users"
      @users = User.paginate(:page => params[:page])
    end
    
    def show
      @user = User.find(params[:id])
      @title = @user.name
    end
    
    def new
      @user = User.new
      @title = "Sign up"
    end
    
    def create
      @user = User.new(params[:user])
      if @user.save
        sign_in @user
        flash[:success] = "Welcome to the Sample App!"
        redirect_to @user
      else
        @title = "Sign up"
        render 'new'
      end
    end
    
    def edit
      @title = "Edit user"
    end
    
    def update
      @user = User.find(params[:id])
      if @user.update_attributes(params[:user])
        flash[:success] = "Profile updated"
        redirect_to @user
      else
        @title = "Edit user"
        render 'edit'
      end
    end
    
    def destroy
      User.find(params[:id]).destroy
      flash[:success] = "User destroyed."
      redirect_to users_path
    end
    
    private
    
      def authenticate
        deny_access unless signed_in?
      end
    
      def correct_user
        @user = User.find(params[:id])
        redirect_to(root_path) unless current_user?(@user)
      end
    
      def admin_user
        redirect_to(root_path) unless current_user.admin?
      end
    end
    

    9
    задан RBergs 2 November 2011 в 16:27
    поделиться